-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectors-ci: handle strict encrypt connectors #25864
connectors-ci: handle strict encrypt connectors #25864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits, otherwise lgtm!
@@ -430,10 +430,16 @@ def build_include(self) -> List[str]: | |||
Returns: | |||
List[str]: List of directories or files to be mounted to the container to run a Java connector Gradle task. | |||
""" | |||
additional_inclusion = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Why an array and not a single value?
@@ -430,10 +430,16 @@ def build_include(self) -> List[str]: | |||
Returns: | |||
List[str]: List of directories or files to be mounted to the container to run a Java connector Gradle task. | |||
""" | |||
additional_inclusion = [] | |||
if self.context.connector.technical_name.endswith("-strict-encrypt"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: it would be great if we had a more explicit mapping
related_connectors = {
"source-file-secure": ["source-file"],
"source-postgres-strict-encrypt": ["source-postgres"]
# ...
,}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to not hardcode and maintain the list of strict-encrypted connectors in the pipeline.
I created a dedicated function that will hopefully provide a bit more readability: dcb6bcc
What
Closes #25846
The strict encrypt connectors were not testable with the CLI because we used the OSS registry to get the list of available connectors.
How
metadata.yaml
file